This repository was archived by the owner on Oct 10, 2020. It is now read-only.
trust, sign: prevent gpg warnings to be printed#1126
Closed
giuseppe wants to merge 1 commit intoprojectatomic:masterfrom
Closed
trust, sign: prevent gpg warnings to be printed#1126giuseppe wants to merge 1 commit intoprojectatomic:masterfrom
giuseppe wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Member
|
Will this eat real errors? Should we not do this when setting the --debug flag? |
giuseppe
force-pushed
the
fix-gpg-warnings
branch
from
1a4eb78 to
19b0821
Compare
I've noticed this warning while using "atomic trust show": gpg: WARNING: no command supplied. Trying to guess what you mean ... Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
fix-gpg-warnings
branch
from
19b0821 to
2062958
Compare
Collaborator
Author
|
I've changed it to redirect stderr to /dev/null only when --debug is not used |
|
LGTM |
Member
|
@giuseppe did you verify that the message comes out when you pass in the debug flag? If so then |
Collaborator
Author
|
yes, I've verified it: @rh-atomic-bot r=rhatdan |
|
📌 Commit 2062958 has been approved by |
|
⚡ Test exempted: merge already tested. |
eyusupov
pushed a commit
to eyusupov/atomic
that referenced
this pull request
Mar 10, 2018
I've noticed this warning while using "atomic trust show": gpg: WARNING: no command supplied. Trying to guess what you mean ... Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: projectatomic#1126 Approved by: rhatdan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed this warning while using "atomic trust show":
gpg: WARNING: no command supplied. Trying to guess what you mean ...
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com