Skip to content

BACKPORT: Overlay2 Quota Support#273

Merged
runcom merged 5 commits intoprojectatomic:docker-1.12.6from
rhvgoyal:overlay-quota
Sep 20, 2017
Merged

BACKPORT: Overlay2 Quota Support#273
runcom merged 5 commits intoprojectatomic:docker-1.12.6from
rhvgoyal:overlay-quota

Conversation

@rhvgoyal
Copy link
Copy Markdown

Backport patches from upstream for supporting quota on overlay2.

Upstream commit: f65fa1f

we see a lot of
```
level=debug msg="Failed to unmount a03b1bb6f569421857e5407d73d89451f92724674caa56bfc2170de7e585a00b-init overlay: device or resource busy"
```
in daemon logs and there is a lot of mountpoint leftover.
This cause failed to remove container.

Signed-off-by: Lei Jitang <leijitang@huawei.com>
Upstream commit: 52897d1

This class implements XFS project quota controls
for setting quota limits on a newly created directory.
It currently supports the legacy XFS specific ioctls.

Using this class, quota limits per container can be set
by directory based storage drivers (e.g. overlay), when
backing storage is XFS mounted with 'pquota' mount option.

TODO: use generic quota control ioctl FS_IOC_FS{GET,SET}XATTR
      for both xfs/ext4 for kernel version >= v4.5

Signed-off-by: Amir Goldstein <amir73il@aquasec.com>
Signed-off-by: albam.c <albam.c@navercorp.com>
Upstream commit: 9ea5071

In kernel version >= v4.5 the project quota ioctl definitions
have been made public via the include/uapi/linux/fs.h API, so
that ext4 could use the same API.

Avoid re-defining the ioctl API if it is already defined in fs.h.

Signed-off-by: Amir Goldstein <amir73il@aquasec.com>
Upstream commit: 05bac45

Allow passing --storage-opt size=X to docker create/run commands
for the `overlay2` graphriver.

The size option is only available if the backing fs is xfs that is
mounted with the `pquota` mount option.
The user can pass any size less then the backing fs size.

Signed-off-by: Amir Goldstein <amir73il@aquasec.com>
Upstream commit: a63d5bc

This commit adds the overlay2.size option to the daemon daemon
storage opts.

The user can override this option by the "docker run --storage-opt"
options.

Signed-off-by: Dhawal Yogesh Bhanushali <dbhanushali@vmware.com>
@rhvgoyal
Copy link
Copy Markdown
Author

@rhatdan @runcom PTAL

@rhvgoyal
Copy link
Copy Markdown
Author

cc @mbarnes

@runcom
Copy link
Copy Markdown
Collaborator

runcom commented Sep 19, 2017

LGTM

1 similar comment
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Sep 20, 2017

LGTM

@runcom runcom merged commit 85d7426 into projectatomic:docker-1.12.6 Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants