Proposed improved to issue 97 with better 'no_tag' matching#122
Open
roadSurfer wants to merge 1 commit intoprojectatomic:masterfrom
Open
Proposed improved to issue 97 with better 'no_tag' matching#122roadSurfer wants to merge 1 commit intoprojectatomic:masterfrom
roadSurfer wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make the matching for "no_tag" more discrete and this appears to work, although no doubt a RegEx expert could improve it further.
I discovered that using tags like ":some-tag" and ":some_tag" lead to the tests failing with and invalid parameter error, I will log that as a separate issue.