-
Notifications
You must be signed in to change notification settings - Fork 2
feat: move anaconda branding here instead of on ublue-os/packages #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We refer to these files from the <https://github.com/ublue-os/packages> repo on the <https://github.com/projectbluefin/iso> repo Sister PR: projectbluefin/iso#11 Signed-off-by: Tulip Blossom <tulilirockz@outlook.com>
Summary of ChangesHello @tulilirockz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes the Anaconda installer's branding assets for Bluefin OS by relocating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new CSS file for Anaconda branding. The changes are straightforward, but I've identified a redundant CSS rule. Removing this duplication will improve the maintainability of the code. Please see my specific comment for details.
| /* Add the product logo at the top */ | ||
| .product-logo { | ||
| background-image: none; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block defining the .product-logo class is redundant, as it's already defined on lines 24-27. The earlier definition is more complete. Additionally, the comment on line 42, "Add the product logo at the top", is misleading since the rule sets background-image: none;. Removing this entire block will improve code clarity and maintainability.
We refer to these files from the https://github.com/ublue-os/packages repo on the https://github.com/projectbluefin/iso repo
Sister PR: projectbluefin/iso#11