Skip to content

Conversation

@rwaltr
Copy link
Contributor

@rwaltr rwaltr commented Jan 10, 2026

Simple mise integration

Enables auto mise activation if installed. (includes it in cli brewfile)

Can disable by setting MISE_[SHELL]_AUTO_ACTIVATE=0

If mise is installed, enables packages to be used for the user by running mise -g use [package], then running mise install

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates mise by adding it to the Homebrew cli.Brewfile for installation and creating a shell activation script in /etc/profile.d. The activation script automatically runs mise activate for Bash and Zsh sessions, with an option to disable this behavior. My review focuses on improving the robustness of the shell detection logic in the activation script. I've suggested a more portable and reliable method for identifying the current shell, which will ensure the activation works correctly across different scenarios.

Copy link
Member

@tulilirockz tulilirockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make this a part of bling instead IMHO

@rwaltr
Copy link
Contributor Author

rwaltr commented Jan 10, 2026

shifted to bling.sh

@rwaltr rwaltr marked this pull request as ready for review January 10, 2026 22:55
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 10, 2026
@dosubot
Copy link

dosubot bot commented Jan 10, 2026

Related Documentation

Checked 8 published document(s) in 0 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

tulilirockz
tulilirockz approved these changes Jan 10, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2026
@castrojo castrojo added this pull request to the merge queue Jan 11, 2026
Merged via the queue into projectbluefin:main with commit 880b3c0 Jan 11, 2026
2 checks passed
@castrojo castrojo added kind/bug Something isn't working area/bling Anything to do with motd, terminal bling, charm and gum things area/brew Homebrew things area/dx Developer experience and removed kind/bug Something isn't working labels Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bling Anything to do with motd, terminal bling, charm and gum things area/brew Homebrew things area/dx Developer experience lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants