-
Notifications
You must be signed in to change notification settings - Fork 20
fix(mise): Auto install and activate mise unless told otherwise #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request integrates mise by adding it to the Homebrew cli.Brewfile for installation and creating a shell activation script in /etc/profile.d. The activation script automatically runs mise activate for Bash and Zsh sessions, with an option to disable this behavior. My review focuses on improving the robustness of the shell detection logic in the activation script. I've suggested a more portable and reliable method for identifying the current shell, which will ensure the activation works correctly across different scenarios.
Assisted-by: Gemini via Web
tulilirockz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make this a part of bling instead IMHO
|
shifted to bling.sh |
Simple mise integration
Enables auto mise activation if installed. (includes it in cli brewfile)
Can disable by setting
MISE_[SHELL]_AUTO_ACTIVATE=0If mise is installed, enables packages to be used for the user by running
mise -g use [package], then runningmise install