Skip to content

feat: use dynamic hostname in menu label#272

Merged
castrojo merged 1 commit intoprojectbluefin:mainfrom
dylanmtaylor:dynamic-hostname-label
Apr 13, 2026
Merged

feat: use dynamic hostname in menu label#272
castrojo merged 1 commit intoprojectbluefin:mainfrom
dylanmtaylor:dynamic-hostname-label

Conversation

@dylanmtaylor
Copy link
Copy Markdown
Contributor

@dylanmtaylor dylanmtaylor commented Apr 13, 2026

Now that StorageB/custom-command-menu#10 added support for $(command) substitution in labels, replace the hardcoded "Bluefin" section header with $(hostname) so the menu displays the machine's actual hostname.

Follow-up to #264.

Now that StorageB/custom-command-menu#10 added support for
$(command) substitution in labels, replace the hardcoded
'Bluefin' section header with $(hostname) so the menu
displays the machine's actual hostname.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/bling Anything to do with motd, terminal bling, charm and gum things labels Apr 13, 2026
@dylanmtaylor
Copy link
Copy Markdown
Contributor Author

Note that while this PR is in its final state, we need to wait for the new version to be tagged and pushed to GNOME extensions before merging this in.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dconf configuration for the custom command menu by replacing the static 'Bluefin' label with the system's hostname via a shell variable. I have no feedback to provide as there are no review comments.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2026
@castrojo castrojo merged commit 30d3d37 into projectbluefin:main Apr 13, 2026
2 checks passed
@dylanmtaylor dylanmtaylor deleted the dynamic-hostname-label branch April 13, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bling Anything to do with motd, terminal bling, charm and gum things lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants