Skip to content

fix: don't show failure message on bluefin-cli#303

Open
renner0e wants to merge 1 commit intomainfrom
no-scary-exit-message
Open

fix: don't show failure message on bluefin-cli#303
renner0e wants to merge 1 commit intomainfrom
no-scary-exit-message

Conversation

@renner0e
Copy link
Copy Markdown
Contributor

@renner0e renner0e commented May 5, 2026

When you decline ujust bluefin-cli with "I'm boring", which happens in ublue-bling, gum will exit with 1, this in turn makes the just recipe fail. It confuses users and makes it seem like the recipe didn't behave as expected.

error: Recipe `aurora-cli` failed on line 36 with exit code 1

Summary by CodeRabbit

  • Chores
    • Adjusted system output behavior to reduce message verbosity during operations.

When you decline `ujust bluefin-cli` with "I'm boring", which happens in
ublue-bling, gum will exit with 1, this in turn makes the just
recipe fail. It confuses users and makes it seem like the recipe didn't
behave as expected.

```
error: Recipe `aurora-cli` failed on line 36 with exit code 1
```
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/bling Anything to do with motd, terminal bling, charm and gum things area/just Justfile things kind/bug Something isn't working labels May 5, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 561df3f3-4ec6-4eb2-8810-c6cd37d78b8c

📥 Commits

Reviewing files that changed from the base of the PR and between b5ea358 and 461285c.

📒 Files selected for processing (1)
  • system_files/bluefin/usr/share/ublue-os/just/system.just

📝 Walkthrough

Walkthrough

A single [no-exit-message] directive is added to the System recipe group in a justfile, suppressing the display of exit messages when that group's recipes complete execution.

Changes

System Recipe Output Configuration

Layer / File(s) Summary
Justfile Directive
system_files/bluefin/usr/share/ublue-os/just/system.just
The [no-exit-message] directive is added to the group('System') section to suppress exit message output for all recipes in that group.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny directive, swift and keen,
Hops through the justfile unseen,
No exit messages shall appear—
The System group runs without cheer! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title references suppressing a failure message on bluefin-cli, which aligns with the changeset's addition of [no-exit-message] to suppress the System recipe group's exit message output.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch no-scary-exit-message

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bling Anything to do with motd, terminal bling, charm and gum things area/just Justfile things kind/bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants