Skip to content

fix(just): return to ujust menu after bbrew and cncf submenus#357

Open
hanthor wants to merge 2 commits into
mainfrom
fix/bbrew-return-to-menu
Open

fix(just): return to ujust menu after bbrew and cncf submenus#357
hanthor wants to merge 2 commits into
mainfrom
fix/bbrew-return-to-menu

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented May 29, 2026

Summary

Closes #126

After bbrew or cncf exits, calls ujust --choose to return the user to the main ujust recipe list instead of dropping them to the terminal.

This addresses the UX issue where exiting bbrew's TUI submenu leaves the user at a shell prompt with no way back to the recipe menu.

Changes

  • system_files/shared/usr/share/ublue-os/just/apps.just: add ujust --choose after bbrew invocation in both bbrew and cncf recipes

Test plan

  • Run ujust --choose → select bbrew → exit bbrew → verify ujust choose menu reappears
  • Run ujust --choose → select cncf → exit bbrew → verify ujust choose menu reappears

After bbrew or cncf exits, call 'ujust --choose' to return the user
to the main ujust recipe list instead of dropping to terminal.

Closes #126
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@hanthor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ff56fdd2-59d0-4199-b1f6-95802174cd13

📥 Commits

Reviewing files that changed from the base of the PR and between d28b37e and 516f097.

📒 Files selected for processing (1)
  • system_files/shared/usr/share/ublue-os/just/apps.just
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bbrew-return-to-menu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added area/just Justfile things kind/bug Something isn't working labels May 29, 2026
Copy link
Copy Markdown
Member Author

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #357 — return to ujust menu after bbrew and cncf

Simple, correct fix for #126. Two one-line additions that return users to the ujust menu after brew submenu operations instead of dropping them to shell.

What's good

  • Minimal change — exactly the right scope
  • Pattern consistent across both bbrew and cncf submenus
  • No side effects — ujust --choose is already the standard return path

Verdict

LGTM. Ready to merge.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 30, 2026
@castrojo castrojo enabled auto-merge May 30, 2026 04:34
@castrojo
Copy link
Copy Markdown
Contributor

🤖 Copilot Test Report

Branch: fix/bbrew-return-to-menu | 6 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Notes

Adds return-to-menu after bbrew and cncf submenus. Simple one-liner fix to ujust navigation flow.

Copy link
Copy Markdown
Contributor

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.

@castrojo
Copy link
Copy Markdown
Contributor

🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed.

@castrojo
Copy link
Copy Markdown
Contributor

Hey @hanthor — could you rebase this onto main? A new e2e smoke suite was added as a required status check and it hasn't run on this branch yet. Once it passes we can enqueue. Also needs your approval on the castrojo-authored PRs (#339) to clear the 2-reviewer requirement.

@castrojo castrojo closed this May 30, 2026
auto-merge was automatically disabled May 30, 2026 07:38

Pull request was closed

@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
@hanthor hanthor enabled auto-merge May 30, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/just Justfile things kind/bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

leaving bbrew from inside a submenu provided by ujust should return user to the list and not the terminal

2 participants