fix(just): return to ujust menu after bbrew and cncf submenus#357
fix(just): return to ujust menu after bbrew and cncf submenus#357hanthor wants to merge 2 commits into
Conversation
After bbrew or cncf exits, call 'ujust --choose' to return the user to the main ujust recipe list instead of dropping to terminal. Closes #126
|
Warning Review limit reached
More reviews will be available in 44 minutes and 51 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hanthor
left a comment
There was a problem hiding this comment.
Review: PR #357 — return to ujust menu after bbrew and cncf
Simple, correct fix for #126. Two one-line additions that return users to the ujust menu after brew submenu operations instead of dropping them to shell.
What's good
- Minimal change — exactly the right scope
- Pattern consistent across both
bbrewandcncfsubmenus - No side effects —
ujust --chooseis already the standard return path
Verdict
LGTM. Ready to merge.
🤖 Copilot Test ReportBranch: Test Results
NotesAdds return-to-menu after bbrew and cncf submenus. Simple one-liner fix to ujust navigation flow. |
castrojo
left a comment
There was a problem hiding this comment.
✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.
|
🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed. |
Summary
Closes #126
After
bbreworcncfexits, callsujust --chooseto return the user to the main ujust recipe list instead of dropping them to the terminal.This addresses the UX issue where exiting bbrew's TUI submenu leaves the user at a shell prompt with no way back to the recipe menu.
Changes
system_files/shared/usr/share/ublue-os/just/apps.just: addujust --chooseafterbbrewinvocation in bothbbrewandcncfrecipesTest plan
ujust --choose→ selectbbrew→ exit bbrew → verify ujust choose menu reappearsujust --choose→ selectcncf→ exit bbrew → verify ujust choose menu reappears