fix(ujust): only run brew bundle when enabling bluefin-cli#358
Conversation
Previously the bluefin-cli recipe always ran 'brew bundle' after toggling bling, which meant disabling bling would reinstall all Homebrew CLI packages unnecessarily. Now the recipe checks whether bling is already installed before toggling, and only runs brew bundle when enabling (i.e., bling was not previously installed). Closes #164
|
Warning Review limit reached
More reviews will be available in 54 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hanthor
left a comment
There was a problem hiding this comment.
Reviewed: Only runs brew bundle when explicitly enabling bluefin-cli. Correct fix — prevents unnecessary brew operations on every ujust invocation.
🤖 Copilot Test ReportBranch: Test Results
ChangeExpands
|
| PR | Approach |
|---|---|
| #358 (this) | Full shell expansion — detects shell type, checks if bling was installed, skips brew on disable |
| #362 | One-liner: ublue-bling && brew bundle — simple short-circuit, brew only runs if bling enable succeeds |
These cannot both merge. #358 is the more correct fix (brew should be skipped when disabling). #362 is a partial fix (brew skips on bling failure, but still runs on disable if bling 'succeeds' at disabling).
Summary
Fixes #164:
ujust bluefin-clino longer reinstalls Homebrew CLI packages when disabling bling.Problem
The
bluefin-clirecipe always ranbrew bundle --file=/usr/share/ublue-os/homebrew/cli.Brewfileafter toggling bling. When a user disabled bling, the recipe would:Fix
Before toggling bling, the recipe now checks whether bling is currently installed (by looking for the bling source line in the shell config). It only runs
brew bundlewhen bling was not installed — meaning the user is enabling bling.Closes #164
Test plan
ujust bluefin-cliwhen bling is enabled should disable bling without reinstalling brew packagesujust bluefin-cliwhen bling is disabled should enable bling and install brew packages