fix: add help: URI handler to redirect to GNOME help website#494
fix: add help: URI handler to redirect to GNOME help website#494castrojo wants to merge 2 commits into
Conversation
dosubot
Bot
added
size:XS
|
Warning Review limit reached
More reviews will be available in 52 minutes and 48 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds a GNOME help URI handler desktop entry and publishes a second-pass ACMM Level 1 audit documenting five new blindspots, systemic obstacles, updated recommendations, and revised issue tracking with parity matrices. The help handler addresses the missing help URI scheme support (issue ChangesGNOME Help URI Handler Registration
ACMM Level 1 Second-Pass Audit Report
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
castrojo
force-pushed
the
fix/help-uri-handler
branch
2 times, most recently
from
c354254 to
045a43e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@system_files/bluefin/usr/bin/bluefin-help`:
- Around line 29-33: The script currently treats a trailing slash URI (where
PAGE is empty) as a page and ends up opening ".../stable/.html"; update the
branch that decides between app-index and page by checking for an empty PAGE as
well as PAGE == APP: in the conditional around PAGE and APP (the existing
elif/else block), change the test so that if PAGE is empty (e.g. [[ -z "${PAGE}"
]] ) or PAGE equals APP ( "${PAGE}" == "${APP}" ) it opens
"https://help.gnome.org/users/${APP}/stable/" otherwise it opens the page URL
"https://help.gnome.org/users/${APP}/stable/${PAGE}.html".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ffe76196-f7f4-4dcf-ac08-7c2dac68bf80
📒 Files selected for processing (2)
system_files/bluefin/usr/bin/bluefin-helpsystem_files/bluefin/usr/share/applications/bluefin-help.desktop
| elif [[ "${PAGE}" == "${APP}" ]]; then | ||
| # No slash → only an app name was given | ||
| xdg-open "https://help.gnome.org/users/${APP}/stable/" | ||
| else | ||
| xdg-open "https://help.gnome.org/users/${APP}/stable/${PAGE}.html" |
There was a problem hiding this comment.
Handle trailing-slash app URIs to avoid malformed .html targets.
help:<app>/ currently falls into the page branch and opens .../stable/.html. Treat empty PAGE as app-index routing.
Suggested fix
-if [[ -z "${APP}" ]]; then
+if [[ -z "${APP}" ]]; then
xdg-open "https://help.gnome.org/"
-elif [[ "${PAGE}" == "${APP}" ]]; then
+elif [[ "${PAGE}" == "${APP}" || -z "${PAGE}" ]]; then
# No slash → only an app name was given
xdg-open "https://help.gnome.org/users/${APP}/stable/"
else
xdg-open "https://help.gnome.org/users/${APP}/stable/${PAGE}.html"
fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| elif [[ "${PAGE}" == "${APP}" ]]; then | |
| # No slash → only an app name was given | |
| xdg-open "https://help.gnome.org/users/${APP}/stable/" | |
| else | |
| xdg-open "https://help.gnome.org/users/${APP}/stable/${PAGE}.html" | |
| elif [[ "${PAGE}" == "${APP}" || -z "${PAGE}" ]]; then | |
| # No slash → only an app name was given | |
| xdg-open "https://help.gnome.org/users/${APP}/stable/" | |
| else | |
| xdg-open "https://help.gnome.org/users/${APP}/stable/${PAGE}.html" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@system_files/bluefin/usr/bin/bluefin-help` around lines 29 - 33, The script
currently treats a trailing slash URI (where PAGE is empty) as a page and ends
up opening ".../stable/.html"; update the branch that decides between app-index
and page by checking for an empty PAGE as well as PAGE == APP: in the
conditional around PAGE and APP (the existing elif/else block), change the test
so that if PAGE is empty (e.g. [[ -z "${PAGE}" ]] ) or PAGE equals APP (
"${PAGE}" == "${APP}" ) it opens "https://help.gnome.org/users/${APP}/stable/"
otherwise it opens the page URL
"https://help.gnome.org/users/${APP}/stable/${PAGE}.html".
Bluefin removes yelp, leaving no handler for help: and ghelp: URI schemes. This breaks the Nautilus Templates folder tooltip's "Learn More" button (help:gnome-help/files-templates). Add a minimal shell script and .desktop file that intercepts x-scheme-handler/help and x-scheme-handler/ghelp and redirects to the equivalent page on help.gnome.org. Closes projectbluefin/bluefin#306 Assisted-by: Claude Sonnet 4.6 via GitHub Copilot CLI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castrojo
force-pushed
the
fix/help-uri-handler
branch
from
045a43e to
8388793
Compare
acmm-audit-level1.md was 637 lines, exceeding the 500-line hard limit enforced by the skill-drift check. Extract sections 7-9 (follow-up findings, updated parity matrix, complete issue batch) to new reference file acmm-audit-level1-followup.md. Update INDEX.md accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castrojo
force-pushed
the
fix/help-uri-handler
branch
from
fe892ad to
fb26366
Compare
|
Closing in favor of #501 which cherry-picks just the help URI handler fix on top of current main. PR #494 had accumulated 613 commits of divergence which made it unmergeable without a massive rebase. The docs/skills changes in this PR that aren't already in main can be sent as separate targeted PRs if needed. |
1 participant
Problem
Bluefin removes
yelp, leaving no registered handler forhelp:andghelp:URI schemes. This breaks the Nautilus Templates folder tooltip's Learn More button (help:gnome-help/files-templates), which shows "No Apps Available". The secondary "Find more in Software" failure is fromgnome-softwarealso being removed.Closes projectbluefin/bluefin#306
Solution
Add a minimal shell script (
/usr/bin/bluefin-help) and.desktopfile that registers as thex-scheme-handler/helpandx-scheme-handler/ghelphandler. When invoked, it translates the URI into the equivalenthelp.gnome.orgURL and opens it in the default browser.URI mapping:
help:gnome-help/files-templates→https://help.gnome.org/users/gnome-help/stable/files-templates.htmlhelp:<app>/<page>→https://help.gnome.org/users/<app>/stable/<page>.htmlhelp:<app>→https://help.gnome.org/users/<app>/stable/Files land in
system_files/bluefin/(not shared) since this is specific to Bluefin variants that remove yelp — Aurora keeps yelp and should not be affected.Summary by CodeRabbit
New Features
Documentation