-
Notifications
You must be signed in to change notification settings - Fork 20
feat: disable atuin shell integration by default #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Atuin shell integration is now disabled by default in bluefin-cli. The atuin binary remains installed via Homebrew and is available for manual use. Users who want shell integration can uncomment the initialization line in their shell config. This change affects both bash/zsh (bling.sh) and fish (bling.fish). Assisted-by: Claude 3.5 Sonnet via GitHub Copilot
Summary of ChangesHello @castrojo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request shifts the default behavior of Atuin's shell integration from an opt-out model to an opt-in model. The core Atuin binary remains installed and accessible, but its automatic shell integration features are now commented out by default, allowing users to explicitly enable them if desired. This change aims to provide users with greater control over their shell environment's initial configuration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables atuin shell integration by default in bling.sh and bling.fish, making it an opt-in feature. The changes correctly comment out the initialization lines and add instructions for users who wish to re-enable it. My feedback focuses on improving the new comments to retain important contextual information that was present before, such as the correct initialization order relative to starship and instructions for customizing atuin's behavior. This will help users avoid potential misconfigurations.
Summary
Disables atuin shell integration by default in bluefin-cli while keeping the atuin binary installed via Homebrew.
Changes
bling.sh(bash/zsh)bling.fishRationale
Users can still access atuin commands manually, but the shell integration (up-arrow and ctrl-r hijacking) is now opt-in rather than opt-out.
Testing
cli.Brewfileand will be installed