docs(downloads,driver-versions): fix links and remove backup ISO section#685
Conversation
Align GDX URL labels, remove the legacy backup ISO block from Downloads, and add a bootc preflight check on Driver Versions to prevent manifest mismatch errors before switching tags. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation by synchronizing Bluefin GDX download link text with their URLs, removing the 'Older Backup ISOs' section, and introducing a 'bootc switch preflight' tip in the driver versions guide. Feedback was provided regarding the preflight bash script, specifically addressing a logic error where the switch command would execute regardless of the check's success and a likely incorrect image path due to redundant organization prefixes.
| IMAGE_NAME=$(jq -r '."image-name"' < /usr/share/ublue-os/image-info.json) | ||
| TARGET_TAG=stable | ||
| skopeo inspect docker://ghcr.io/ublue-os/${IMAGE_NAME}:${TARGET_TAG} >/dev/null | ||
| sudo bootc switch --enforce-container-sigpolicy ghcr.io/ublue-os/${IMAGE_NAME}:${TARGET_TAG} |
There was a problem hiding this comment.
The preflight check logic is flawed because the skopeo command and the bootc switch command are executed independently; the switch will proceed even if the check fails. Furthermore, the image path ghcr.io/ublue-os/${IMAGE_NAME} likely results in a double organization prefix (e.g., ghcr.io/ublue-os/ublue-os/...) because the image-name field in /usr/share/ublue-os/image-info.json typically already includes the organization. This is inconsistent with the DriverVersionsCatalog component on the same page which uses ghcr.io/${IMAGE_NAME}.
IMAGE_NAME=$(jq -r '."image-name"' < /usr/share/ublue-os/image-info.json)
TARGET_TAG=stable
skopeo inspect docker://ghcr.io/${IMAGE_NAME}:${TARGET_TAG} >/dev/null && sudo bootc switch --enforce-container-sigpolicy ghcr.io/${IMAGE_NAME}:${TARGET_TAG}
Ensure the first page at / renders with the docs sidebar expanded and prevent missing images catalog data from breaking the site build. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use ghcr.io/ and chain skopeo inspect with bootc switch so the switch only runs when the target tag exists. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
Align GDX URL labels, remove the legacy backup ISO block from Downloads, and add a bootc preflight check on Driver Versions to prevent manifest mismatch errors before switching tags.
Assisted-by: Claude Sonnet 4.6 via GitHub Copilot