Skip to content

fix(images): wire fetch-github-images into fetch-data chain#686

Merged
castrojo merged 1 commit intoprojectbluefin:mainfrom
castrojo:upstream-pr/fix-images-fetch-data
Mar 31, 2026
Merged

fix(images): wire fetch-github-images into fetch-data chain#686
castrojo merged 1 commit intoprojectbluefin:mainfrom
castrojo:upstream-pr/fix-images-fetch-data

Conversation

@castrojo
Copy link
Copy Markdown
Contributor

The fetch-github-images.js script existed but was never added to the fetch-data npm script. As a result, static/data/images.json was never generated during npm start or npm run build, causing the /images page to render blank (the component falls back to an empty product list when the fetch returns 404).

Adds the fetch-github-images script entry and inserts it into the fetch-data chain so images.json is generated on every build and dev server start.

Assisted-by: Claude Sonnet 4.6 via OpenCode

The fetch-github-images.js script existed but was never added to the
fetch-data npm script. As a result, static/data/images.json was never
generated during npm start or npm run build, causing the /images page
to render blank (the component falls back to an empty product list when
the fetch returns 404).

Adds the fetch-github-images script entry and inserts it into the
fetch-data chain so images.json is generated on every build and dev
server start.

Assisted-by: Claude Sonnet 4.6 via OpenCode
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo castrojo merged commit 3bb6c27 into projectbluefin:main Mar 31, 2026
1 check passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new script fetch-github-images to the project and updates the fetch-data command to include it. A critical issue was identified in package-lock.json where the typescript dependency is listed with a non-existent version (6.0.2) and an integrity hash that matches version 5.0.2. This mismatch will cause installation failures and indicates potential manual tampering or a supply chain risk, requiring the lockfile to be regenerated.

Comment thread package-lock.json
"resolved": "https://registry.npmjs.org/typescript/-/typescript-6.0.2.tgz",
"integrity": "sha512-bGdAIrZ0wiGDo5l8c++HWtbaNCWTS4UTv7RaTH/ThVIgjkveJt83m74bBHMJkuCbslY8ixgLBVZJIOiQlQTjfQ==",
"devOptional": true,
"dev": true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The typescript package entry in package-lock.json contains a critical inconsistency. The version is listed as 6.0.2 (which does not exist in the official npm registry), yet the integrity hash (sha512-bGdAIr...) corresponds to version 5.0.2. This mismatch will cause npm install to fail with an integrity check error. Furthermore, using a non-existent version of a core dependency from the public registry is a strong indicator of a potential supply chain attack or manual tampering. Please revert any manual edits to the lockfile and regenerate it by running npm install to ensure all dependencies are correctly resolved and verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant