fix(firehose): always fetch fresh app data in CI#703
Merged
castrojo merged 1 commit intoApr 1, 2026
Conversation
The committed firehose-apps.json seed is an empty array. When CI restores the GHA data cache it writes the file with a fresh mtime, causing fetch-firehose.js to skip the fetch (cache appears < 6h old). The result is an empty changelogs page on the live site. Two fixes: - scripts/fetch-firehose.js: read FIREHOSE_CACHE_HOURS env var (default 6h); also skip the cache when the apps array is empty, regardless of mtime. - .github/workflows/pages.yml: set FIREHOSE_CACHE_HOURS=0 so CI always fetches fresh data, matching the DRIVER_VERSIONS_CACHE_HOURS=0 pattern already in use. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the fetch-firehose.js script to support a configurable cache duration via the FIREHOSE_CACHE_HOURS environment variable. Additionally, it implements a check to force a fresh data fetch if the local cache file is empty or contains invalid JSON, ensuring data integrity. The logic for cache bypass and logging has been refactored to accommodate these changes. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed firehose-apps.json seed is an empty array. When CI restores the GHA data cache it writes the file with a fresh mtime, causing fetch-firehose.js to skip the fetch (cache appears < 6h old). The result is an empty changelogs page on the live site.
Two fixes:
Assisted-by: Claude Sonnet 4.6 via GitHub Copilot