fix(components,scripts,ci): p2 component and script fixes#713
Conversation
Fixes #22: DriverVersionsCatalog — formatDate UTC timezone, deprecated word-break CSS → overflow-wrap:anywhere, jq bracket notation, versionMissing CSS applied directly from nullable values Fixes #23: FeedItems — stopPropagation on ActionLinkButton/ContributorAvatar inside anchor cards; GHCR packageTagUrl uses raw registry tag (lts.YYYYMMDD) not normalized form; formatLongDate UTC timezone Fixes #25: Pin actions/cache@v5 → @668228422ae6a00e4ad889ee87cd7109ec5666a7 (v5.0.4) in monthly-reports.yml and pdf.yml Fixes #26: fetch-github-images.js attestation lookup prefers exact stream ID match before falling back to org/package family Fixes #51: FirehoseFeed featured app selection moved to useEffect/useState — eliminates SSR/hydration date mismatch Fixes #53: fetchReleases follows Link header pagination — no longer capped at 100 releases (bluefin-lts already has 192) Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
259a5a9 to
f56908c
Compare
There was a problem hiding this comment.
Code Review
This pull request implements GitHub API pagination for release fetching and refactors SBOM version lookups with improved normalization and fallback logic. Key updates include standardizing date formatting to UTC, fixing a shell command syntax error in the driver catalog, and updating CSS for better text wrapping. UI components were also enhanced to handle event propagation and support additional LTS tag formats. Feedback was provided regarding a duplicated regular expression in FeedItems.tsx that should be extracted into a constant to improve maintainability.
I am having trouble creating individual review comments. Click here to see my feedback.
src/components/FeedItems.tsx (330-338)
The regex /(stable-\d{8}|beta-\d{8}|latest-\d{8}|lts[-.]\d{8})/i is duplicated in extractReleaseTag and getSupplyChainLinks. This should be defined as a constant to ensure consistency and maintainability.
Fixes #22: DriverVersionsCatalog — formatDate UTC timezone, deprecated word-break CSS → overflow-wrap:anywhere, jq bracket notation, versionMissing CSS applied directly from nullable values
Fixes #23: FeedItems — stopPropagation on ActionLinkButton/ContributorAvatar inside anchor cards; GHCR packageTagUrl uses raw registry tag (lts.YYYYMMDD) not normalized form; formatLongDate UTC timezone
Fixes #25: Pin actions/cache@v5 → @668228422ae6a00e4ad889ee87cd7109ec5666a7 (v5.0.4) in monthly-reports.yml and pdf.yml
Fixes #26: fetch-github-images.js attestation lookup prefers exact stream ID match before falling back to org/package family
Fixes #51: FirehoseFeed featured app selection moved to useEffect/useState — eliminates SSR/hydration date mismatch
Fixes #53: fetchReleases follows Link header pagination — no longer capped at 100 releases (bluefin-lts already has 192)
Assisted-by: Claude Sonnet 4.6 via GitHub Copilot