fix(images): make downloads optional to prevent crash when field abse…#740
Merged
castrojo merged 1 commit intoApr 12, 2026
Merged
Conversation
…nt from data product.downloads was a required field in the Product interface but fetch-github-images.js never writes it, causing a runtime TypeError on production at product.downloads.display. Make downloads optional and guard the statsRow render so the page loads cleanly when pull-count data is unavailable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Product interface to make the downloads field optional and nullable. It also adds a conditional check in the ImagesCatalogComponent to safely render download statistics only when the data is present, preventing potential runtime errors. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt from data
product.downloads was a required field in the Product interface but fetch-github-images.js never writes it, causing a runtime TypeError on production at product.downloads.display.
Make downloads optional and guard the statsRow render so the page loads cleanly when pull-count data is unavailable.