Skip to content

fix(artwork): remove duplicate Duality (Ultrawide) entry#754

Merged
castrojo merged 1 commit into
projectbluefin:mainfrom
castrojo:fix/artwork-workflow-eof-delimiter
Apr 13, 2026
Merged

fix(artwork): remove duplicate Duality (Ultrawide) entry#754
castrojo merged 1 commit into
projectbluefin:mainfrom
castrojo:fix/artwork-workflow-eof-delimiter

Conversation

@castrojo
Copy link
Copy Markdown
Contributor

The duality-ultrawide entry in artwork.json was a duplicate of the existing duality entry (same artwork, same author/credits). Removing to keep the gallery clean.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Assisted-by: Claude Sonnet 4.6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo castrojo merged commit d8e4985 into projectbluefin:main Apr 13, 2026
1 check passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the duality-ultrawide entry from the artwork metadata. The review feedback highlights that this removal results in the loss of a nightUrl reference that is missing from the primary duality entry and notes that the entry will likely be re-added by the automated sync script unless the script's skip list is updated.

I am having trouble creating individual review comments. Click here to see my feedback.

static/data/artwork.json (283-297)

high

Removing the duality-ultrawide entry results in the loss of the nightUrl reference (line 292), which is currently missing from the remaining duality entry (line 320). If these represent the same artwork, the nightUrl should be preserved in the remaining entry to avoid data loss.

Additionally, since scripts/update-artwork.mjs automatically syncs wallpapers based on directory names in the upstream repository, this entry will likely be re-added the next time the script runs. To prevent this, the duality-ultrawide directory should be added to the SKIP_DIRS set in the sync script.

@castrojo castrojo deleted the fix/artwork-workflow-eof-delimiter branch May 9, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant