Skip to content

Add unit coverage for ssh_steps helpers#200

Merged
castrojo merged 1 commit into
mainfrom
feat/quality/ssh-steps-unit-tests
Jun 1, 2026
Merged

Add unit coverage for ssh_steps helpers#200
castrojo merged 1 commit into
mainfrom
feat/quality/ssh-steps-unit-tests

Conversation

@castrojo
Copy link
Copy Markdown
Collaborator

@castrojo castrojo commented Jun 1, 2026

Summary

  • add unit tests for the remaining uncovered assertion helpers in tests/shared/ssh_steps.py
  • cover both pass and failure paths for output assertions and direct journal/coredump checks
  • verify the exact subprocess.run invocations for journalctl and coredumpctl

Testing

  • python3 -m pytest tests/unit/test_ssh_steps.py -v
  • python3 -m ruff check tests/unit/test_ssh_steps.py --select E,F,W --ignore E501
  • python3 -m ruff check tests/ --select E,F,W --ignore E501 (currently fails on pre-existing W605 issues in tests/unit/test_gnome_shell_steps.py)

Closes #197

Add unit tests for the remaining uncovered ssh_steps helpers and direct subprocess checks.\n\nCloses #197\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo castrojo added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 455dacb Jun 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] ssh_steps.py: no_journal_entries_match and no_coredump_entries_exist untested

1 participant