-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Optimize error prompts #10295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize error prompts #10295
Conversation
Signed-off-by: DrAuYueng <ouyang1204@gmail.com>
|
@DrAuYueng Thanks for the PR - before we can merge you'll need to sign the CLA to make the bot happy. Is this in service of some other goal? Or just something you noticed? I would expect this error to always be the same thing, so not especially useful to log out. |
|
@caseydavenport IMO, |
|
/sem-approve |
|
Makes sense, thanks @DrAuYueng |
Signed-off-by: DrAuYueng <ouyang1204@gmail.com>
|
Removing "merge-when-ready" label due to new commits |
|
@caseydavenport CI check failed due to error judgment problem. I just fixed it. Please take a look again. Thanks. |
|
/sem-approve |
Description
Improve the error message of
ErrorResourceAlreadyExiststype to avoid losing the original Err.Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.