Merged
Conversation
lwr20
force-pushed
the
ext-svc-test
branch
2 times, most recently
from
b9cc02e to
3d7bade
Compare
lwr20
force-pushed
the
ext-svc-test
branch
3 times, most recently
from
7a4ec13 to
ed986df
Compare
lwr20
force-pushed
the
ext-svc-test
branch
7 times, most recently
from
3b597f7 to
27645c5
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- Dockerfile: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
pkg/qperf/qperf.go:346
- Ensure to import the 'strconv' package in pkg/qperf/qperf.go so that converting the control port value to a string works correctly.
controlPortStr := strconv.Itoa(port)
pkg/config/config_test.go:255
- [nitpick] Consider using consistent key naming in the YAML test definitions (e.g., 'numPolicies' instead of 'numpolicies') to match the established naming convention in the rest of the configuration.
numpolicies: 100
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lwr20
commented
Apr 9, 2025
radTuti
reviewed
Apr 14, 2025
Comment on lines
+141
to
+142
| ControlPort int // The port to use for the control connection in tests. Used by qperf tests. | ||
| TestPort int // The port to use for the test connection in tests. Used by qperf and iperf tests |
There was a problem hiding this comment.
are these only used for external-service-pod tests
Member
Author
There was a problem hiding this comment.
No, these are used for all qperf and iperf tests. They do get defaulted if not specified however.
radTuti
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends tiger-bench to be able to run external->service->pod tests, measuring latency and throughput using
qperf, as the tool did before.These tests are run from where-ever the test is being run from. The tests do NOT include setting up the service (because there are too many possible ways to expose a service to the world in kubernetes).
The README should explain how to set up the service for the test to work (broadly - expose 2 ports, make sure you do not map the port numbers between the pod and the outside world).
Some extra configuration parameters were needed to tell the tool how the service has been exposed (port numbers, etc). Also added was the ability to specify whether or not to run pod-pod, pod-svc-pod or ext-svc-pod tests. And finally, the results format was extended to include ext-svc-pod test results.