Use Command and Args properly#29
Merged
lwr20 merged 2 commits intoprojectcalico:mainfrom Dec 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Kubernetes pod specifications to properly separate Command and Args fields, and applies gofmt formatting across multiple Go files. The changes fix potential runtime issues where commands were incorrectly specified only in the Args field without an explicit Command.
Key changes:
- Separated Command and Args in pod specifications for qperf, iperf, and dnsperf containers
- Removed unused
argsparameter frommakeDeploymentfunction in the cluster package - Applied gofmt formatting to align struct fields in test files and result structures
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/qperf/qperf.go | Moved qperf command from Args to Command field, properly separating executable path from arguments |
| pkg/iperf/iperf.go | Moved shell invocation (/bin/sh -c) from Args to Command field for correct execution |
| pkg/dnsperf/dnsperf.go | Moved shell invocation from Args to Command field (also standardized to /bin/sh) and fixed comment spacing |
| pkg/cluster/cluster_internal.go | Removed unused args parameter from makeDeployment function signature and removed Args field from container spec |
| pkg/cluster/cluster.go | Updated makeDeployment function calls to remove the now-unused args parameter |
| pkg/stats/stats_test.go | Applied gofmt formatting to align struct field names in test cases |
| pkg/results/results.go | Applied gofmt formatting to align struct field types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glen-Tigera
approved these changes
Dec 17, 2025
lwr20
added a commit
that referenced
this pull request
Dec 18, 2025
* label each pod with at least as many labels as policies (#26) * label each pod with at least as many labels as policies * allow for no test to run, just setup env * generate total mesh of policies that are not groupped * Use Command and Args properly (#29) --------- Co-authored-by: Tomas Hruby <49207409+tomastigera@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And run goftmt over all go files