Skip to content
This repository was archived by the owner on Oct 20, 2025. It is now read-only.

push and tag-images targets#156

Merged
caseydavenport merged 1 commit into
projectcalico:masterfrom
deitch:cross-images
May 29, 2018
Merged

push and tag-images targets#156
caseydavenport merged 1 commit into
projectcalico:masterfrom
deitch:cross-images

Conversation

@deitch

@deitch deitch commented May 24, 2018

Copy link
Copy Markdown
Collaborator

Description

  • Add standard push, push-all, tag-images, tag-images-all targets to Makefile to simplify cross-arch image creation
  • Simplify Makefile by leveraging the above
  • Use var CONTAINER_NAME throughout to standardize

Follows pattern approved from felix, kube-controller, etc.

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

Standard push targets

None required

@fasaxc fasaxc self-requested a review May 24, 2018 12:40
@fasaxc fasaxc self-assigned this May 24, 2018
@caseydavenport caseydavenport merged commit 4810e33 into projectcalico:master May 29, 2018
@deitch

deitch commented May 29, 2018

Copy link
Copy Markdown
Collaborator Author

Thanks @caseydavenport

@deitch deitch deleted the cross-images branch May 29, 2018 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants