Conversation
hedibouattour
force-pushed
the
refactor-service-caching
branch
from
33935b7 to
f8d2794
Compare
hedibouattour
force-pushed
the
refactor-service-caching
branch
from
f8d2794 to
ea85208
Compare
hedibouattour
force-pushed
the
refactor-service-caching
branch
from
ea85208 to
35634e5
Compare
sknat
reviewed
Jan 7, 2026
Collaborator
sknat
left a comment
sknat
left a comment
There was a problem hiding this comment.
Many thanks for taking a stab at this. This looks good, but I think we might still be vulnerable to overrides in VPP that will cause double free. Details inline
hedibouattour
force-pushed
the
refactor-service-caching
branch
2 times, most recently
from
e9a660c to
e9c1969
Compare
sknat
reviewed
Jan 13, 2026
Collaborator
sknat
left a comment
sknat
left a comment
There was a problem hiding this comment.
Many thanks for the udpate! A few more comments inline, tell me if you want to discuss
Previously, entries were cached by entry key only. This caused issues when multiple services referenced the same entry. This update changes the caching logic to: * Cache each entry by service ID while allowing multiple services to target the same entry. * When multiple services reference the same entry, override the previous value and keep the latest. * On service entry deletion, check whether other services still reference the same entry; if so, recreate the entry. This ensures consistent behavior when entries are shared across services.
hedibouattour
force-pushed
the
refactor-service-caching
branch
from
e9c1969 to
db5466d
Compare
sknat
approved these changes
Jan 14, 2026
Collaborator
sknat
left a comment
sknat
left a comment
There was a problem hiding this comment.
lgtm, thanks for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, entries were cached by entry key only. This caused issues when multiple services referenced the same entry.
This update changes the caching logic to:
Cache each entry by service ID while allowing multiple services to target the same entry.
When multiple services reference the same entry, override the previous value and keep the latest.
On service entry deletion, check whether other services still reference the same entry; if so, recreate the entry.
This ensures consistent behavior when entries are shared across services.