fix(helm): fix default securitycontext for job#998
Merged
oliverbaehler merged 1 commit intoprojectcapsule:mainfrom Mar 30, 2026
Merged
fix(helm): fix default securitycontext for job#998oliverbaehler merged 1 commit intoprojectcapsule:mainfrom
oliverbaehler merged 1 commit intoprojectcapsule:mainfrom
Conversation
Signed-off-by: sandert-k8s <sandert98@gmail.com>
sandert-k8s
force-pushed
the
fix-securitycontext-defaults
branch
from
ec709c7 to
c55d0e2
Compare
There was a problem hiding this comment.
Pull request overview
Restores the intended default hardening for the Helm chart’s CRD lifecycle (kubectl) Job by re-enabling the default pod/container security contexts, and updates the chart metadata/docs to reflect the corrected defaults.
Changes:
- Set
global.jobs.kubectl.podSecurityContext.enableddefault back totrue. - Set
global.jobs.kubectl.securityContext.enableddefault back totrue. - Update README defaults table and ArtifactHub changelog entry to match.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/capsule-proxy/values.yaml | Re-enables default pod/container securityContext toggles for the kubectl Job. |
| charts/capsule-proxy/README.md | Updates documented default values for the kubectl Job security contexts. |
| charts/capsule-proxy/Chart.yaml | Records the fix in artifacthub.io/changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prometherion
approved these changes
Mar 27, 2026
oliverbaehler
approved these changes
Mar 30, 2026
oliverbaehler
pushed a commit
that referenced
this pull request
Apr 14, 2026
Signed-off-by: sandert-k8s <sandert98@gmail.com> Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by mistake disabled the default securityContext for the kubectl job in this PR. Fixed this.