fix: correct helm values schema for webservcie ports#1928
Merged
Conversation
Signed-off-by: bakito <github@bakito.ch>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Allows the webhook service port field to accept an integer value (in addition to null) in the Capsule Helm chart schema.
Changes:
- Updated schema annotation in
values.yamlfor bothconversions.service.portandwebhooks.service.portto allow integer or null. - Updated
values.schema.jsonto reflect the new[integer, null]type for both port fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/capsule/values.yaml | Adds @schema type:[integer, null] annotations to the two port fields. |
| charts/capsule/values.schema.json | Updates the port property type from "null" to ["integer", "null"] in both webhook service definitions. |
Contributor
Author
|
helm-docs did not update correctly yet, don't know how to tell the tool how to change the type or the null value. |
oliverbaehler
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the helm schema for webhook ports