Skip to content

fix: correct helm values schema for webservcie ports#1928

Merged
oliverbaehler merged 1 commit into
projectcapsule:mainfrom
bakito:webhook-ports
May 29, 2026
Merged

fix: correct helm values schema for webservcie ports#1928
oliverbaehler merged 1 commit into
projectcapsule:mainfrom
bakito:webhook-ports

Conversation

@bakito
Copy link
Copy Markdown
Contributor

@bakito bakito commented May 29, 2026

Correct the helm schema for webhook ports

Signed-off-by: bakito <github@bakito.ch>
Copilot AI review requested due to automatic review settings May 29, 2026 07:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Allows the webhook service port field to accept an integer value (in addition to null) in the Capsule Helm chart schema.

Changes:

  • Updated schema annotation in values.yaml for both conversions.service.port and webhooks.service.port to allow integer or null.
  • Updated values.schema.json to reflect the new [integer, null] type for both port fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/capsule/values.yaml Adds @schema type:[integer, null] annotations to the two port fields.
charts/capsule/values.schema.json Updates the port property type from "null" to ["integer", "null"] in both webhook service definitions.

@bakito
Copy link
Copy Markdown
Contributor Author

bakito commented May 29, 2026

helm-docs did not update correctly yet, don't know how to tell the tool how to change the type or the null value.

@oliverbaehler oliverbaehler merged commit ce6fb68 into projectcapsule:main May 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants