Bump ruby version to latest patch #817
Conversation
Make sure our built versions build off a specific version, not just the 2.2 latest release. This is in conjunction with projectcypress/cypress#817 in order to bring the two into sync.
|
Is the proper way for me to fix this to target this towards the 3.2 branch or some different way? |
|
If you're targeting 3.2, you should make the Pull Request against the |
|
That was more meant in reference to the failing bundler audit since we are on an insecure version of nokogiri on master. Does that mean we are not planning to have another point release for the 3.1 branch? If we are then this PR should be against master since otherwise the upgrade script will try to downgrade everyone who is running the latest version of the cypress vm down to ruby 2.2.5. If we are not going to have another 3.1.x point release though then there is no problem with this being against 3.2. |
|
This pull request can be made against the |
It turns out that due to a mistake in https://github.com/projectcypress/cypress-recipe/blob/master/resources/install_app.rb#L9 that all users are already running 2.2.6 anyway, so we may as well develop against it as well.
It turns out that due to a mistake in https://github.com/projectcypress/cypress-recipe/blob/master/resources/install_app.rb#L9 that all users are already running 2.2.6 anyway, so we may as well develop against it as well.