keep per-provider data on partial failures and surface errors in fingerprint generation#499
keep per-provider data on partial failures and surface errors in fingerprint generation#499Mzack9999 wants to merge 1 commit into
Conversation
…erprint generation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
WalkthroughThis PR changes provider source compilation from fail-fast to error-accumulating behavior. A new CIDR deduplication helper merges results across multiple sources while preserving order and preventing duplicates. Input processing now accumulates errors and continues through all providers instead of returning immediately on failure. A CLI ChangesProvider source compilation with error resilience
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
generate.Compile/Category.fetchInputItemno longer abort an entire category on the first failing URL or ASN. Per-source errors are accumulated and joined.getIpInfoASNnow includes IPv6 prefixes (Prefixes6).cmd/generate-indexgains a-strictflag (defaulttrue) so a failing provider source surfaces as a non-zero exit, instead of silently producing an incompletesources_data.json.Fingerprint Updateworkflow bumpsactions/checkout@v4andactions/setup-go@v5, and adds ajq -eguard that fails the run if any top-level category collapses to zero providers.This was triggered by silent data loss in recent runs (e.g. WAF Akamai disappearing from
sources_data.jsonafter ipinfo started returning 401 for the first ASN of the category).Closes #375
Test plan
go test ./...go vet ./...Fingerprint Updateafter merge + token rotation to confirm Akamai/Sucuri/Leaseweb repopulate.Summary by CodeRabbit
New Features
-strictflag to control provider source compilation failure behavior; when disabled, generation continues with available data despite failures.Bug Fixes