Skip to content

Adding session resume support #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 3 commits into from
Apr 20, 2022
Merged

Adding session resume support #262

ehsandeep merged 3 commits into from
Apr 20, 2022

Conversation

@Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Apr 14, 2022

Description

This PR adds support for session resume from file through a new -sf flag used to specify the session file

Example:

$ interactsh-client -sf resume.yaml        

    _       __                       __       __
   (_)___  / /____  _________ ______/ /______/ /_
  / / __ \/ __/ _ \/ ___/ __ '/ ___/ __/ ___/ __ \
 / / / / / /_/  __/ /  / /_/ / /__/ /_(__  ) / / /
/_/_/ /_/\__/\___/_/   \__,_/\___/\__/____/_/ /_/ 1.0.2

                projectdiscovery.io

[INF] Listing 1 payload for OOB Testing
[INF] c9c1mpg33t22pp16bae0wfc7xaaq1bx5o.oast.live
exit status 1

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Apr 14, 2022
@Mzack9999 Mzack9999 self-assigned this Apr 14, 2022
@Mzack9999 Mzack9999 linked an issue Apr 14, 2022 that may be closed by this pull request
Poll interactions from existing / persist session #257
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Apr 14, 2022
@Mzack9999
Copy link
Member Author

Mzack9999 commented Apr 15, 2022 •
edited
Loading

Todo before merging:

  • Check if -persist is needed or can be superseded by session resume implementation

ehsandeep
ehsandeep approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove persist flag in favor of sf flag.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
2.3% 2.3% Duplication

@Mzack9999 Mzack9999 requested a review from ehsandeep April 16, 2022 11:27
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Apr 20, 2022
@ehsandeep ehsandeep merged commit 1e797c1 into dev Apr 20, 2022
@ehsandeep ehsandeep deleted the issue-257-session-resume branch April 20, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poll interactions from existing / persist session

4 participants

@Mzack9999 @ehsandeep @Ice3man543