refactor: switch from Knetic/govaluate to projectdiscovery fork (#751)#752
Draft
ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
Draft
refactor: switch from Knetic/govaluate to projectdiscovery fork (#751)#752ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
Conversation
…ectdiscovery#751) Replaces github.com/Knetic/govaluate with github.com/projectdiscovery/govaluate to align with the rest of the projectdiscovery ecosystem (dsl, nuclei). Temporary `replace` directive points dsl at the PR branch (projectdiscovery/dsl#305) until that lands and is tagged. Will drop the replace and bump dsl once the upstream tag exists. Closes projectdiscovery#751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #751.
Swaps
github.com/Knetic/govaluateforgithub.com/projectdiscovery/govaluateso proxify lines up with the rest of the projectdiscovery ecosystem.Code change is one import line in
internal/runner/runner.go. The rest of the diff isgo mod tidychurn.Sibling PRs
Why draft
dsl.DefaultHelperFunctionsis typed againstKnetic/govaluate.ExpressionFunction, so until dsl#305 ships and is tagged, this build only goes green with a temporaryreplacedirective pointing at the PR branch:Once dsl#305 merges and a fresh dsl tag is cut, I'll drop the
replacehere and bump dsl to the tag, then mark this ready for review.Verified
go build ./...cleango vet ./...cleango test ./...clean (no test files in tree)