Perform GloWGR input validation #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 90 90
Lines 4339 4340 +1
Branches 406 379 -27
=======================================
+ Hits 4068 4069 +1
Misses 271 271
Continue to review full report at Codecov.
|
Signed-off-by: Karen Feng <karen.feng@databricks.com>
karenfeng
changed the title
…ut-validation Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
| """ | ||
| __assert_all_present(labeldf, 'label') | ||
| __check_standardized(labeldf, 'label') | ||
| __assert_all_present(covdf, 'covariate') |
Contributor
There was a problem hiding this comment.
We should also check standardization of covariates here.
Collaborator
Author
There was a problem hiding this comment.
Done, thanks for the review! Can you take a second look?
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
...main/scala/io/projectglow/transformers/blockvariantsandsamples/VariantSampleBlockMaker.scala
Outdated
Show resolved
Hide resolved
...main/scala/io/projectglow/transformers/blockvariantsandsamples/VariantSampleBlockMaker.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Signed-off-by: Karen Feng <karen.feng@databricks.com>
henrydavidge
approved these changes
Jun 26, 2020
Contributor
henrydavidge
left a comment
henrydavidge
left a comment
There was a problem hiding this comment.
One nit, LGTM after addressing.
...main/scala/io/projectglow/transformers/blockvariantsandsamples/VariantSampleBlockMaker.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adds the following input validation steps to GloWGR.
sig == 0duringassemble_block.To cut down slightly on runtime, I also wrote out the level 1-reduced GT matrix to use in tests that don't require the original block GT matrix.
How is this patch tested?