Add an adapter for Shingoncoder #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
shingon
branch
2 times, most recently
from
af96e12 to
aa7670d
Compare
|
So Shingoncoder intends to accept and return JSON according to zencoder's API? It also appears that this adapter is still a prototype and needs to be filled out with status updating, errors, etc. but all that work will happen in shingoncoder. Is that what you expect? |
Shingoncoder is a backend for transcoding videos locally using ActiveJob and Ffmpeg https://github.com/jcoyne/shingoncoder
|
It conforms to the JapaneseBuddhismCoder API. What is zencoder? 😉 Yep, adapter is still prototype, but seems to work fine for the "create" case, which is mostly what I care about. |
|
👏 Thanks for doing this work. It will be very useful to avalonmediasystem and hopefully others. |
cjcolvar
added a commit
that referenced
this pull request
Sep 28, 2015
Add an adapter for Shingoncoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shingoncoder is a backend for transcoding videos locally using ActiveJob and Ffmpeg
https://github.com/jcoyne/shingoncoder
Please merge PR #2 first. Then I can rebase this PR on master.