feat: GH-issue cluster #17-#23 work-down + accumulated cleanup#24
Merged
Conversation
Wave 1 (#23): document 6 pk-doctor check modules (v2_contracts, context_hygiene, schema_vocabulary, migration_integrity, mcp_gateway, skill_dag). Wave 2 (#21, #22): v1 entity penalty in router/skill-finder/index- management with configurable v1_entity_penalty knob (default 0.3); new pk-doctor v1_entity_drift check. Wave 3 (#17, #18, #19): compliance-contract.md rebuild (6 sections, positive-leaning, action-first); sub-agent-dispatch clause; task-router recommended_team_member_slug + recommended_model_class fields; AGENTS.md "Before sub-agent dispatch" section; new pk-doctor team_member_exports check; slim hook injection (~14 lines) via BEGIN/END HOOK markers; export_claude_subagent self-describing TeamMember + RuntimeBinding header; harness docs. Wave 4 (#20): team-creator v2 design epic split into 5 sub-WorkItems (TidyAsh/LuckyWren/RapidLily/SwiftReef/MerryPlum); cross-gap design synthesis filed as ART-20260509_1836-SmartPanda; SUB-5 codename rename shipped (12 replacements). 5 cross-cutting decisions recorded (SmoothLynx, LivelyClover, MerryFjord, MightySky, CoolBadger). Includes accumulated working-tree state from prior sessions: applied 8 migrations 0.23.11 -> 0.25.6, dropped legacy .agents/skills/pk-* and .claude/commands/pk-*.md shims, removed bulk skill catalog stubs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Foundational RoleSlot primitive WorkItem moves backlog -> in-progress ahead of dispatch on a separate branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 9, 2026
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes/addresses 7 GitHub issues in 4 sequenced waves, plus accumulated working-tree state from prior sessions (8 applied migrations 0.23.11→0.25.6, legacy
.agents/skills/pk-*and.claude/commands/pk-*.mdshim removal, bulk skill-catalog stub removal undercontext/skills/{data-ai,design,devops,documents,engineering,product}/).7 of 7 GH-issue WorkItems are in review state apart from VastVale (#20) which is in-progress as a decomposed epic with 5 sub-WorkItems (4 backlog, 1 review).
Wave 1 — pk-doctor SKILL.md docs (closes #23)
Documented 6 previously-undocumented check modules in
context/skills/processkit/pk-doctor/SKILL.md:v2_contracts,context_hygiene,schema_vocabulary,migration_integrity,mcp_gateway,skill_dagWave 2 — v1-drift cluster (closes #21, #22)
v1_entity_drift(~265 lines): per-file v1 frontmatter scan with v2 successor table.task-router/mcp/user_config.json) — applied at SKILL.mdapiVersionlevel AND at index-level entity reads (query_entities,get_entity,search_entities).Wave 3 — agent-dispatch cluster (closes #17, #18, #19)
compliance-contract.mdrebuilt: 6 sections (On session start / Sub-agent dispatch / Tool routing / Entity writes / Decisions / Prohibitions), action-first phrasing, ~10 positive : 4 negative imperatives.recommended_team_member_slug+recommended_model_class.task-routerresponse shape extended:recommended_team_member_slug(resolves Cora for 5/14 PM-owned domain groups today; engineering-role mapping is a follow-up),recommended_model_class.AGENTS.md"Before sub-agent dispatch" section added.team_member_exports: warns when active TeamMembers lack.claude/agents/<slug>.mdexports (3 WARNs against this repo).<!-- BEGIN HOOK -->/<!-- END HOOK -->markers in compliance-contract.md;emit_compliance_contract.pyextracts the slim block onUserPromptSubmit(~14 lines) and the full contract onSessionStart. Per-turn token tax cut from ~60 to ~14 lines. (Per-turn hook → session-skill migration, gh#19 rec 1, was rejected — see DEC-LivelyClover.)export_claude_subagentnow writes a self-describing TeamMember + RuntimeBinding header in generated agent files.skill-builder,skill-reviewer,team-creator,agent-management) markedskillOverrides=name-onlyin the documented harness settings.docs/harness-claude-code.md+docs/harness-claude-code.settings.example.json.Wave 4 — team-creator v2 design epic (in-progress, #20)
ART-20260509_1836-SmartPanda— recommends RoleSlot+TeamMember hybrid identity model, direct catalog consumption, consultant TeamMember type with engagement_window, budget_projection in chartering DEC inputs_snapshot, two-phase additive-then-cutover migration.get_pricingfor budget unit costs.team-creator/tree.Decisions recorded (5)
Tests
task-router: 9 tests passing (added v1 penalty + sub-agent dispatch field tests)skill-gate: 87 hook tests passing (added slim-payload + full-contract assertions)team-manager: 56 tests passing (addedexport_claude_subagentheader assertions)pk-doctorv1_entity_drift: smoke-tested viapy_compileonly (sandbox blocked pyyaml import)Test plan
route_taskreturnsrecommended_team_member_slug/recommended_model_classv1_entity_drift,team_member_exports) emit expected findingsUserPromptSubmit, full contract onSessionStartdiff -r --exclude=__pycache__ context/skills/processkit/ src/context/skills/processkit/Open follow-ups (not in this PR)
recommended_team_member_slugresolves only 5/14 PM-owned groups; add ROLE-software-engineer mapping.semantic_search_entitiesandhybrid_search_entitiesnot yet covered by v1 penalty.ROLE-assistantarchetype mapping target) — defaulting to architect's recommendations..claude/settings.jsonis_processkit_managed(installer-rewritten) —skillOverridesandenv.ENABLE_TOOL_SEARCH=autodocumented but not auto-applied.🤖 Generated with Claude Code