Improve Virus on Network documentation #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
pre-commit checks failed: https://results.pre-commit.ci/run/github/42205414/1708283306.gaMzyn-PS4uAHxWwbDygnQ. |
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
EwoutH
reviewed
Feb 19, 2024
Member
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is a valuable improvement to this example!
There is one minor issue with our formatter, once that's fixed it looks good to me to merge!
Member
|
@coderbeta1 Welcome and thanks for the contribution! This is a super minor fix, if you would prefer we can do it on our end, just let us know. Thanks again |
EwoutH
reviewed
Feb 22, 2024
EwoutH
approved these changes
Feb 22, 2024
EwoutH
changed the title
Member
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1: Make the ReadMe more descriptive
Change 2: Doc Strings and Cleaning
Made small changes to make the code more readable and easy to understand at first glance
NOTE: In the model, after running, some of the nodes in the graph are isolated. In my opinion it should be connected (if it was intentional then fine but in case not it needs to be updated with a different graph creation technique)