Skip to content

[Feat] 커스텀 타이머 삭제 api 연결 #258#260

Merged
edv-Shin merged 2 commits intofeat/custom-timer-225from
feat/custom-timer-delete-258
Aug 29, 2025
Merged

[Feat] 커스텀 타이머 삭제 api 연결 #258#260
edv-Shin merged 2 commits intofeat/custom-timer-225from
feat/custom-timer-delete-258

Conversation

@edv-Shin
Copy link
Contributor

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

#258

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

커스텀 타이머 삭제 api 연결

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@edv-Shin edv-Shin added this to the 타이머 기능 배포 milestone Aug 26, 2025
@edv-Shin edv-Shin requested a review from yunjaena August 26, 2025 09:03
@edv-Shin edv-Shin self-assigned this Aug 26, 2025
private set

var customTimerId: Long? = null
var customTimerId: Long = -1L
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

외부로 공개하는 이유가 뭔가요? Viewmodel에서 처리 가능해 보입니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f655014
수정했습니다!

@edv-Shin edv-Shin changed the base branch from feat/custom-timer-create-api-256 to feat/custom-timer-225 August 29, 2025 12:58
@edv-Shin edv-Shin merged commit 983d305 into feat/custom-timer-225 Aug 29, 2025
@edv-Shin edv-Shin deleted the feat/custom-timer-delete-258 branch January 29, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants