Skip to content

fix(CICD) : 특정 테스트코드가 CI/CD 과정에서 배포 안되는 오류 수정#542

Merged
joohyun1996 merged 1 commit intodevelopfrom
fix/CICD
Feb 18, 2026
Merged

fix(CICD) : 특정 테스트코드가 CI/CD 과정에서 배포 안되는 오류 수정#542
joohyun1996 merged 1 commit intodevelopfrom
fix/CICD

Conversation

@joohyun1996
Copy link
Contributor

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

스크린샷 (선택)

API 응답 사진: (API 응답 스크린샷을 첨부해주세요.)

API 명세서 사진: (API 명세서 스크린샷을 첨부해주세요.)

테스트 커버리지 사진: (테스트 커버리지 스크린샷을 첨부해주세요.)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

#️⃣연관된 이슈

ex) #이슈번호, Closes #이슈번호

Copilot AI review requested due to automatic review settings February 18, 2026 02:44
@joohyun1996 joohyun1996 merged commit b031c24 into develop Feb 18, 2026
4 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dev CI/CD GitHub Actions workflow to address CI failures where Testcontainers-based tests couldn’t access Docker during the pipeline run.

Changes:

  • Added a workflow step to adjust /var/run/docker.sock permissions so Testcontainers can connect to Docker on the runner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +59 to +62
# [추가] Docker 소켓 권한 부여 (Testcontainers가 접근할 수 있도록)
- name: Grant permission for Docker socket
run: sudo chmod 666 /var/run/docker.sock
shell: bash
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo chmod 666 /var/run/docker.sock makes the Docker daemon socket world-writable. Even on ephemeral GitHub-hosted runners this is an avoidable escalation surface. Prefer a least-privilege approach (e.g., chgrp docker + chmod 660 on the socket and ensure the runner user is in the docker group), or use the officially supported Testcontainers/GitHub Actions setup that doesn’t require opening permissions to all users.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants