Skip to content

(bug) Flux Source Artifact changes #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Mar 13, 2025
Merged

(bug) Flux Source Artifact changes #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion controllers/clustersummary_predicates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ func fluxGenericPredicate(obj client.Object, logger logr.Logger) bool {
}

func hasArtifactChanged(objNew, objOld client.Object) bool {
addTypeInformationToObject(getManagementClusterClient().Scheme(), objNew)
switch objNew.GetObjectKind().GroupVersionKind().Kind {
case sourcev1.GitRepositoryKind:
newGitRepo := objNew.(*sourcev1.GitRepository)
Expand Down Expand Up @@ -312,5 +313,5 @@ func isArtifactSame(oldArtifact, newArtifact *sourcev1.Artifact) bool {
if oldArtifact != nil && newArtifact == nil {
return false
}
return reflect.DeepEqual(oldArtifact, newArtifact)
return reflect.DeepEqual(oldArtifact.Digest, newArtifact.Digest)
}