(bug) handle helm chart errors in pullmode#1725
Merged
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom Apr 19, 2026
Merged
(bug) handle helm chart errors in pullmode#1725gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
Conversation
8b3a17e to
9f906a3
Compare
Member
Author
|
ClusterSummary Status featureSummaries:
- consecutiveFailures: 35
failureMessage: |
values don't meet the specifications of the schema(s) in the following chart(s):
cert-manager:
- at '/crds': additional properties 'replicas' not allowed
featureID: Helm
hash: B2G6wtbQhKUtF0v+KHC5r7qxVhltPre/I36fvFGtwMk=
lastAppliedTime: "2026-04-18T20:28:36Z"
status: Failed
helmReleaseSummaries:
- failureMessage: |
values don't meet the specifications of the schema(s) in the following chart(s):
cert-manager:
- at '/crds': additional properties 'replicas' not allowed
releaseName: cert-manager
releaseNamespace: cert-manager
status: Managing
valuesHash: uHgnUljrEBsWynaXJjcLt0c5djSe1eNQ7xiaoopttaE=
nextReconcileTime: "2026-04-18T20:29:36Z"all resources are still on the managed cluster |
f3f0944 to
63479b2
Compare
Previously, when Sveltos processed a Helm chart in pull mode, it would generate ConfigurationBundle instances as it prepared the resources. If an error was encountered halfway through this process, Sveltos would still commit the resources it had successfully prepared up to that point. This led to a critical synchronization failure: 1. Partial State: The ConfigurationBundle contained only a subset of the intended resources. 2. Applier Misinterpretation: The applier would treat the missing resources as "deleted" or "out of scope," causing it to prune existing resources on the managed cluster or deploy an incomplete, broken stack. This PR introduces atomic preparation logic. If an error occurs at any point during the preparation of resources for a Helm chart: 1. Discard: All partially prepared resources are discarded. 2. No Commit: Nothing is committed to the ConfigurationBundle, ensuring the applier does not act on incomplete data. 3. Report: The error is captured and reported specifically within the ClusterSummary status for visibility.
63479b2 to
e8bb8b6
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when Sveltos processed a Helm chart in pull mode, it would generate ConfigurationBundle instances as it prepared the resources. If an error was encountered halfway through this process, Sveltos would still commit the resources it had successfully prepared up to that point.
This led to a critical synchronization failure:
This PR introduces atomic preparation logic. If an error occurs at any point during the preparation of resources for a Helm chart:
Fixes #1724