Skip to content

fix(pull-mode): do not commit helm stage when a chart failed in the cycle #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thecodeassassin wants to merge 1 commit into from
Closed

fix(pull-mode): do not commit helm stage when a chart failed in the cycle #1728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions controllers/handlers_helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,21 @@ func handleCharts(ctx context.Context, clusterSummary *configv1beta1.ClusterSumm
}

if isPullMode {
// If any chart in this reconcile failed to stage (helm values schema
// error, template instantiation failure, unreachable repo, etc.),
// do not commit. Committing a partial staged set produces a
// ConfigurationGroup with missing bundles for the failed charts,
// which the agent in the managed cluster interprets as "these
// releases were removed from the profile" and uninstalls them.
// Returning early leaves the previously-committed ConfigurationGroup
// in place so the agent continues to run the last known good state
// until the reconcile can complete cleanly. This mirrors the
// deployError-before-commit pattern already used in
// handlers_resources.go and handlers_kustomize.go.
if deployError != nil {
return deployError
}

err = commitStagedResourcesForDeployment(ctx, clusterSummary, configurationHash, mgmtResources, logger)
if err != nil {
return err
Expand All @@ -937,10 +952,6 @@ func handleCharts(ctx context.Context, clusterSummary *configv1beta1.ClusterSumm
if err != nil {
return err
}

if deployError != nil {
return deployError
}
} else {
// First get the helm releases currently managed and uninstall all the ones
// not referenced anymore. Only if this operation succeeds, removes all stale
Expand Down
Loading