(bug) when cluster is marked as deleted avoid triggering cleanup#712
Merged
gianlucam76 merged 3 commits intoprojectsveltos:release-0.38from Sep 27, 2024
gianlucam76:cluster-deleted
Merged
(bug) when cluster is marked as deleted avoid triggering cleanup#712gianlucam76 merged 3 commits intoprojectsveltos:release-0.38from gianlucam76:cluster-deleted
gianlucam76 merged 3 commits intoprojectsveltos:release-0.38from
gianlucam76:cluster-deleted
Conversation
Post release v0.38.3
Prepare dev to main merge
Clusters marked as deleted are scheduled for removal once their finalizer is removed. Therefore, initiating cleanup while a cluster is in this state is redundant. Prior to this change, Sveltos would trigger cleanup for a cluster instance even if it was marked as deleted. However, if Sveltos invoked the Helm SDK as part of the cleanup and the Helm uninstall client encountered an unreachable cluster api-server, the Helm SDK would become stuck. To prevent this issue and avoid unnecessary feature cleanup for clusters marked for deletion, this PR has been implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clusters marked as deleted are scheduled for removal once their finalizer is removed.
Therefore, initiating cleanup while a cluster is in this state is redundant.
Prior to this change, Sveltos would trigger cleanup for a cluster instance even
if it was marked as deleted. However, if Sveltos invoked the Helm SDK as part
of the cleanup and the Helm uninstall client encountered an unreachable cluster
api-server, the Helm SDK would become stuck.
To prevent this issue and avoid unnecessary feature cleanup for clusters marked
for deletion, this PR has been implemented.