Skip to content

Updated tutorial to latest versions of Syn components#6

Merged
akosma merged 35 commits intomasterfrom
update
Apr 30, 2021
Merged

Updated tutorial to latest versions of Syn components#6
akosma merged 35 commits intomasterfrom
update

Conversation

@akosma
Copy link
Copy Markdown
Contributor

@akosma akosma commented Apr 22, 2021

This PR updates the tutorial to the latest versions of Syn tools.

@akosma akosma requested review from ccremer and tobru April 23, 2021 12:41
@akosma
Copy link
Copy Markdown
Contributor Author

akosma commented Apr 23, 2021

Ready for review!

Copy link
Copy Markdown
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a deep review here.
I saw sometimes lots of "kubectl --context minikube" and I'm not sure if those commands still work with k8s-in-a-box providers other than minikube? Is the --context flag even required if we have a dedicated kubeconfig file?

@akosma
Copy link
Copy Markdown
Contributor Author

akosma commented Apr 26, 2021

I didn't do a deep review here.
I saw sometimes lots of "kubectl --context minikube" and I'm not sure if those commands still work with k8s-in-a-box providers other than minikube? Is the --context flag even required if we have a dedicated kubeconfig file?

Interesting, at least with minikube and k3d it seems to work fine. The tutorial isn't using a kubeconfig file, but we could indeed.

@ccremer
Copy link
Copy Markdown
Contributor

ccremer commented Apr 26, 2021

The tutorial isn't using a kubeconfig file, but we could indeed.

I would recommend doing that. Having a dedicated kubeconfig ensures no one needs to modify their existing ones and then throwing away the changes again after completing the tutorial.

Copy link
Copy Markdown
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

However, when I gave it a test run locally I found that the setup scripts don't work out of the box on my machine (Btrfs-on-LUKS), see the inline comments on the respective shell scripts.

Possibly similar issues exist for the kind and microk8s scripts.

I also added some notes on a simplified way to setup the Commodore working directory and the component repo's git remote for component development.

Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread docs/modules/ROOT/pages/index.adoc
Comment thread 1_lieutenant_on_minikube.sh
Comment thread 4_synthesize_on_k3s.sh
@akosma
Copy link
Copy Markdown
Contributor Author

akosma commented Apr 28, 2021

The tutorial isn't using a kubeconfig file, but we could indeed.

I would recommend doing that. Having a dedicated kubeconfig ensures no one needs to modify their existing ones and then throwing away the changes again after completing the tutorial.

At least Minikube and K3d both overwrite the local ~/.kube/config upon start, and they remove their respective entries when finished. I suggest using this approach for the moment and update later with a kubeconfig file strategy in a separate PR.

@akosma
Copy link
Copy Markdown
Contributor Author

akosma commented Apr 30, 2021

Having closed all conversations, waiting for @tobru 's approval and we can merge this.

@akosma akosma merged commit 9cbd1b7 into master Apr 30, 2021
@akosma akosma deleted the update branch April 30, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants