Conversation
|
Ready for review! |
ccremer
left a comment
There was a problem hiding this comment.
I didn't do a deep review here.
I saw sometimes lots of "kubectl --context minikube" and I'm not sure if those commands still work with k8s-in-a-box providers other than minikube? Is the --context flag even required if we have a dedicated kubeconfig file?
Interesting, at least with minikube and k3d it seems to work fine. The tutorial isn't using a kubeconfig file, but we could indeed. |
I would recommend doing that. Having a dedicated kubeconfig ensures no one needs to modify their existing ones and then throwing away the changes again after completing the tutorial. |
simu
left a comment
There was a problem hiding this comment.
LGTM overall.
However, when I gave it a test run locally I found that the setup scripts don't work out of the box on my machine (Btrfs-on-LUKS), see the inline comments on the respective shell scripts.
Possibly similar issues exist for the kind and microk8s scripts.
I also added some notes on a simplified way to setup the Commodore working directory and the component repo's git remote for component development.
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
…torial into update
At least Minikube and K3d both overwrite the local ~/.kube/config upon start, and they remove their respective entries when finished. I suggest using this approach for the moment and update later with a kubeconfig file strategy in a separate PR. |
|
Having closed all conversations, waiting for @tobru 's approval and we can merge this. |
This PR updates the tutorial to the latest versions of Syn tools.