Conversation
srueg
force-pushed
the
feature/component-urls
branch
from
4754e16 to
63b1f29
Compare
simu
reviewed
May 20, 2020
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
Overall change LGTM. Will review in more detail on Friday
Contributor
Author
|
For some reason the GitHub actions don't run. They're just stuck in |
simu
requested changes
May 25, 2020
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
The namedtuple config.Component can easily be adjusted/extended to handle the separation of Git repository name and URL base separately which is required for having customizable component URLs.
I would like to have a single Component namedtuple in the code base, also to avoid confusion when working on the dependency management or config code.
Otherwise the error messages might not be correct.
Check if symlink target exists instead of using an exception.
Log less verbose if in non-verbose mode.
If the `-v/--verbose` flag is provided three or more times tracing output is printed. Especially the processing of Kapitan refs polluts the output in debug mode with lots of messages.
srueg
force-pushed
the
feature/component-urls
branch
2 times, most recently
from
7574f25 to
be77e91
Compare
srueg
force-pushed
the
feature/component-urls
branch
2 times, most recently
from
e9ec13d to
158a2c7
Compare
corvus-ch
reviewed
May 25, 2020
simu
approved these changes
May 25, 2020
The component git repo URLs can be overwritten in a global Commodore config file. The config file is searched for in the global inventory repo. The global git base is used as default for non overwritten components. Closes #73
srueg
force-pushed
the
feature/component-urls
branch
from
3d8ccf3 to
3bf352f
Compare
corvus-ch
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overwriting of component git repo URLs.
The component git repo URLs can be overwritten in a global Commodore
config file. The config file is searched for in the global inventory
repo. The global git base is used as default for non overwritten
components.
Closes #73