Skip to content

Allow overriding of component URL in inventory#104

Merged
srueg merged 2 commits intomasterfrom
feature/override-git-url
May 27, 2020
Merged

Allow overriding of component URL in inventory#104
srueg merged 2 commits intomasterfrom
feature/override-git-url

Conversation

@srueg
Copy link
Copy Markdown
Contributor

@srueg srueg commented May 26, 2020

In addition to the version this allows to override the Git URL for a component, using the component_versions dict. This allows for example the usecase of a forked component repository to be used for a certain part of the hierarchy.

Closes #73

@srueg srueg requested review from corvus-ch and simu May 26, 2020 15:08
Comment thread commodore/dependency_mgmt.py Outdated
Comment thread commodore/dependency_mgmt.py Outdated
Comment thread commodore/catalog.py Outdated
@srueg srueg force-pushed the feature/override-git-url branch from e60bd2a to 5daf862 Compare May 27, 2020 07:52
@srueg srueg requested a review from simu May 27, 2020 08:10
@srueg srueg force-pushed the feature/override-git-url branch 2 times, most recently from 77a3eaa to fa61b2c Compare May 27, 2020 08:43
In addition to the version this allows to override the Git URL for a
component, using the `component_versions` dict.
This allows for example the usecase of a forked component repository to
be used for a certain part of the hierarchy.

Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@srueg srueg force-pushed the feature/override-git-url branch from fa61b2c to 49df754 Compare May 27, 2020 09:00
Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@srueg
Copy link
Copy Markdown
Contributor Author

srueg commented May 27, 2020

Tested with:

  • Only overriding the URL (no version)
  • Override url and version with branch
  • Override url and version with tag
  • Override the version (no url)

Copy link
Copy Markdown
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@srueg srueg merged commit 24d96ca into master May 27, 2020
@srueg srueg deleted the feature/override-git-url branch May 27, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow defining full path to Git repository for components

3 participants