Merged
Conversation
simu
added
the
internal
simu
changed the title
We need to ensure that we don't accidentally delete not-yet-tagged images created by other PR's jobs. Additionally, we enable `delete-untagged` for the job that deletes the PR tag after the PR gets closed.
simu
force-pushed
the
ci/ghcr-cleanup-continue-on-error
branch
from
a4072d3 to
f930dd3
Compare
bastjan
approved these changes
Mar 25, 2026
Member
Author
Rationale here: there's a window of opportunity of 1-2 minutes after the per-arch images have been pushed by digest (and are therefore untagged) until the job which creates the tagged multi-arch image completes. Therefore, having a guard of "older than 5 minutes" when cleaning up untagged images after the multi-arch image merge for a PR should be sufficient to never delete not-yet-tagged arch images generated by another PR's job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We configure the cleanup job to not fail the container image merge job when the cleanup fails.
Additionally, we need to ensure that we don't accidentally delete not-yet-tagged images created by other PR's jobs. We do this by only deleting untagged images that are older than 5 minutes in the PR job.
Finally, we enable
delete-untaggedwith no image age restrictions for the job that deletes the PR tag after the PR gets closed, this should ensure that all remaining untagged images left over from the PR are deleted.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog