Conversation
This commit changes Commodore to optionally read the API token from a file. If the API token argument (command line or environment variable) exists as a file, Commodore will read the file contents and use them as the API token. Otherwise the value of the argument is used as the API token. This allows using the service account's token when running Commodore on Kubernetes. Relates: SYN-21
simu
force-pushed
the
allow-api-token-from-file
branch
from
31b6d76 to
a84cf51
Compare
srueg
reviewed
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes Commodore to optionally read the API token from a
file. If the API token argument (command line or environment variable)
exists as a file, Commodore will read the file contents and use them as
the API token. Otherwise the value of the argument is used as the API
token. This allows using the service account's token when running
Commodore on Kubernetes.
Relates: SYN-21