Ensure Commodore binary version is set when pushing image#58
Merged
Conversation
The imported Github action for pushing the docker image to DockerHub does not run the `make docker` command and therefore the Commodore binary version in the pushed image was not configured correctly. This commit generates the binary version as a Github action step instead of relying on the Makefile when building the image to be pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imported Github action for pushing the docker image to DockerHub
does not run the
make dockercommand and therefore the Commodorebinary version in the pushed image was not configured correctly.
This commit generates the binary version as a Github action step instead
of relying on the Makefile when building the image to be pushed.