Conversation
Write tests to ensure behaviour of target rendering. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
srueg
force-pushed
the
optional-facts
branch
6 times, most recently
from
88276b1 to
fa8ca92
Compare
simu
requested changes
May 12, 2020
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
LGTM overall, but it would be great if you can move the variable renaming from commit 0de17c8 into a separate commit to avoid bundling unrelated stuff in a single commit. Having unrelated changes in the same commit usually leads to unnecessary confusion when trying to figure out why a change was made.
The Docker setup is very slow since it copies around a lot of files. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
To also make the region optional. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
To make Flake8 happy Signed-off-by: Simon Rüegg <simon@rueggs.ch>
simu
approved these changes
May 12, 2020
bittner
reviewed
May 12, 2020
bittner
reviewed
May 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the CI setup to skip docker for tox and use GitHub actions matrix build.