Skip to content

Initial implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srueg merged 1 commit into from
Jun 11, 2020
Merged

Initial implementation #1

srueg merged 1 commit into from
Jun 11, 2020

Conversation

@Kidswiss
Copy link
Collaborator

@Kidswiss Kidswiss commented Jun 10, 2020

First iteration of the metrics-server component.

@Kidswiss Kidswiss requested review from simu and srueg June 10, 2020 13:26
simu
simu requested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the helm plugin to render charts (which effectively replicates helm template), you need to activate the helm_namespace postprocessing filter as documented in https://syn.tools/commodore/writing-a-component.html#_postprocessing_filters

srueg
srueg suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@srueg srueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same structure for the image and helm chart as described here in the comment: https://github.com/projectsyn/component-prometheus-adapter/pull/2

@Kidswiss Kidswiss force-pushed the init branch 4 times, most recently from 43214d3 to 2f38d1e Compare June 11, 2020 06:23
@Kidswiss
Copy link
Collaborator Author

Kidswiss commented Jun 11, 2020

Fixed all points.

srueg
srueg reviewed Jun 11, 2020
View reviewed changes
simu
simu approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@srueg
Copy link
Contributor

srueg commented Jun 11, 2020

Please configure the access rights for this repo and add the sig-syn team as owners

@Kidswiss
Copy link
Collaborator Author

Kidswiss commented Jun 11, 2020

@srueg is it possible to configure github that these access rights are automagically applied to all new projects?

@srueg
Copy link
Contributor

srueg commented Jun 11, 2020

@srueg is it possible to configure github that these access rights are automagically applied to all new projects?

Unfortunately not, no

@srueg srueg merged commit a443efb into master Jun 11, 2020
@srueg srueg deleted the init branch June 11, 2020 09:53
@simu simu changed the title Init Initial implementation Jan 19, 2022
@simu simu added the enhancement New feature or request label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simu simu simu approved these changes

+1 more reviewer

@srueg srueg srueg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kidswiss @srueg @simu