Initial implementation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template version: main (804e9c7)
simu
force-pushed
the
initial-implementation
branch
from
dd4bc2d to
14bd0ae
Compare
Member
Author
|
TODO:
|
simu
force-pushed
the
initial-implementation
branch
from
8d0ae99 to
0bb025b
Compare
simu
force-pushed
the
initial-implementation
branch
from
0bb025b to
c444ba0
Compare
bastjan
approved these changes
Jan 24, 2023
docs/modules/ROOT/pages/how-tos/migrate-from-resource-locker.adoc
Outdated
Show resolved
Hide resolved
We copy the resource-locker component library, and update the implementation to generate patch-operator custom resources instead. The additional file `patch-operator-migrate.libsonnet` could be used to provide a transitional `resource-locker.libjsonnet`, if we update Commodore to allow components to steal library prefixes from deprecated components.
Instead, we create a single service account which is granted the cluster role `cluster-admin` by default. The service account name, and granted role can be customized through the component parameters.
We also add a postprocessing filter to ensure that the cert-manager certificate and the openshift serving certificate annotation don't use the same secret name.
Rendered from template version: main (804e9c7)
simu
force-pushed
the
initial-implementation
branch
from
0d28384 to
b4bd15f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.