Conversation
simu
approved these changes
May 14, 2020
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
LGTM. One small language nit, which you can apply or not. Feel free to merge the change yourself afterward.
corvus-ch
suggested changes
May 14, 2020
* Replace SYNventory with Lieutenant API * Update `global` config directory structure * Fix some whitespaces Signed-off-by: Simon Rüegg <simon@rueggs.ch>
Signed-off-by: Simon Rüegg <simon@rueggs.ch>
corvus-ch
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalconfig directory structureSigned-off-by: Simon Rüegg simon@rueggs.ch