Skip to content

Make the tenant GitRepo URL required#83

Merged
srueg merged 1 commit intomasterfrom
require-tenant-giturl
Sep 23, 2020
Merged

Make the tenant GitRepo URL required#83
srueg merged 1 commit intomasterfrom
require-tenant-giturl

Conversation

@srueg
Copy link
Copy Markdown
Contributor

@srueg srueg commented Sep 18, 2020

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

Closes #43

@srueg srueg marked this pull request as ready for review September 18, 2020 13:00
@srueg srueg requested review from corvus-ch, simu and tobru September 18, 2020 13:00
@srueg srueg force-pushed the require-tenant-giturl branch from 2c99e86 to 986e118 Compare September 18, 2020 13:02
Copy link
Copy Markdown
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this effect existing systems? Will there be some upgrade work required? If so, please document.

@srueg
Copy link
Copy Markdown
Contributor Author

srueg commented Sep 22, 2020

How does this effect existing systems? Will there be some upgrade work required? If so, please document.

Double checked and all current Tenant objects have a git URL set. Additionally does the portal require this already, so it's not really a change from it's view. 👍

@srueg srueg merged commit 51fd216 into master Sep 23, 2020
@srueg srueg deleted the require-tenant-giturl branch September 23, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make gitRepo in Tenant object mandatory

4 participants